Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Parallax2D's experimental flag #101983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markdibarry
Copy link
Contributor

We were able to fix a few bugs in 4.3, but overall it seems no major changes are needed for Parallax2D so I think it's safe to remove the experimental flag going forward.

@markdibarry markdibarry requested a review from a team as a code owner January 24, 2025 13:32
@Calinou Calinou added this to the 4.4 milestone Jan 24, 2025
@RedMser
Copy link
Contributor

RedMser commented Jan 24, 2025

Should ParallaxLayer and ParallaxBackground docs be updated (e.g. by marking them as deprecated)? A new user might not know which of these nodes to use now, since they don't refer to each other.

@markdibarry
Copy link
Contributor Author

markdibarry commented Jan 24, 2025

This is just in regards to the stability of Parallax2D that it's safe for users to use in projects. If we're ready to formally say that you shouldn't use the old system, I'm fine with that, but I imagine there'd be a small discussion first and we can make a separate PR for it.

My thought was just to say "it's good to go" for 4.4 and then slowly phase out the old system in 4.5+.

@tetrapod00
Copy link
Contributor

I made the corresponding PR for the manual changes: godotengine/godot-docs#10547.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants