Update list of known breaking changes compared to 4.0-stable #77431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 24, 2023
| Validate extension JSON: Error: Hash mismatch for 'classes/Node3D/methods/look_at_from_position'. This means that the function has changed and no compatibility function was provided. | ||
|
|
||
| Added an optional parameter with a default value. No adjustments should be necessary. |
There was a problem hiding this comment.
Technically adjustments would be needed for GDExtension, no? Re-exposing a compat method without this new argument.
There was a problem hiding this comment.
Well yes, it will need compat binds like #76577, but I didn't add them here as that PR is limbo RN (probably just got lost on the second page of approved PRs), but these comments are mostly target at an user of the engine reading these and they should not need to make any adjustments to deal with the changes.
akien-mga
approved these changes
May 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76647 was just merged and the list is already outdated.
Not adding compat binds here as #76577 has not been merged yet.