Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of known breaking changes compared to 4.0-stable #77431

Merged
merged 1 commit into from
May 24, 2023
Merged

Update list of known breaking changes compared to 4.0-stable #77431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion misc/extension_api_validation/4.0-stable.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,26 @@ GH-77143
--------
Validate extension JSON: Error: Hash mismatch for 'classes/WorkerThreadPool/methods/wait_for_task_completion'. This means that the function has changed and no compatibility function was provided.

Changed the return value from `void` to `Error`. No adjustments should be necessary.
Changed the return value from `void` to `Error`. No adjustments should be necessary.


GH-72842
--------
Validate extension JSON: API was removed: classes/PathFollow2D/methods/get_lookahead
Validate extension JSON: API was removed: classes/PathFollow2D/methods/set_lookahead
Validate extension JSON: API was removed: classes/PathFollow2D/properties/lookahead


GH-77413
--------
Validate extension JSON: Error: Field 'classes/GLTFSkin/properties/godot_skin': type changed value in new API, from "Object" to "Skin".


GH-76082
--------
Validate extension JSON: Error: Hash mismatch for 'builtin_classes/Basis/methods/looking_at'. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash mismatch for 'builtin_classes/Transform3D/methods/looking_at'. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash mismatch for 'classes/Node3D/methods/look_at'. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash mismatch for 'classes/Node3D/methods/look_at_from_position'. This means that the function has changed and no compatibility function was provided.

Added an optional parameter with a default value. No adjustments should be necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically adjustments would be needed for GDExtension, no? Re-exposing a compat method without this new argument.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes, it will need compat binds like #76577, but I didn't add them here as that PR is limbo RN (probably just got lost on the second page of approved PRs), but these comments are mostly target at an user of the engine reading these and they should not need to make any adjustments to deal with the changes.