Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCU build - Change options to "yes / no" #77976

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 7, 2023

To save confusion for users who prefer yes / no, rather than none / all.

(Relates to #77170 )

Notes

  • A couple of maintainers said they would prefer yes / no for the option.

@lawnjelly lawnjelly requested a review from a team as a code owner June 7, 2023 18:34
@lawnjelly lawnjelly added this to the 4.x milestone Jun 7, 2023
@lawnjelly lawnjelly changed the title SCU build - Change options to "no | dev | yes" SCU build - Change options to "yes / no" Jun 7, 2023
@akien-mga
Copy link
Member

We could at a later time simplify the logic as use_scu is now effectively equal to scu_build

I would suggest doing this now, there's no reason to keep both. use_scu can simply be replaced in methods.py now that we've become used to scu_build as the user facing one.

To save confusion for users who prefer yes / no, rather than none / dev / all.
@akien-mga akien-mga merged commit 3566c56 into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the scu_yes_master branch June 9, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants