Expose unused SHADOW_MODULATE's alpha as shadow opacity for 2d lighting shadows #90805
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please open a proposal to track the support and details of this feature 😸 |
Ok~ I've made a proposal here. godotengine/godot-proposals#9541 |
|
Sorry to bother, but would it be possible to get a code review for this pull request, and I would also appreciate any feedback on this. :) |
|
I built and tested the MRP locally and can confirm it does indeed work. Great job! I'm looking forward to utilizing this in my local project. |
maidopi-usagi
force-pushed
the
add_shadow_blendweight
branch
from
cd3823b
to
a35f27f
Compare
maidopi-usagi
force-pushed
the
add_shadow_blendweight
branch
from
a35f27f
to
d0599ca
Compare
|
Rebased to master branch and fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The light built-in
SHADOW_MODULATEis avector4but only first three elements of it are used for modulating the color of shadows, and the alpha channel was totally unused previously.In this pr, the alpha channel of
SHADOW_MODULATEwill modulate the alpha of shadow, so users can change the opacity of received shadows when overridinglight()function.Maybe related to godotengine/godot-proposals#7136 and godotengine/godot-proposals#9297
As
shadow_modulateis initialized tovec4(1.0)before lighting compute , so the default behavior of canvas shaders should not get differences.2024-04-17.23-24-40.mp4
EDIT: made an example Project here
shadow_modulate.zip
Before:
shadow_modulate_alpha_before.mp4
This PR:
shadow_modulate_alpha.mp4