-
-
Notifications
You must be signed in to change notification settings - Fork 20.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Custom Runtime Identifiers #97776
base: master
Are you sure you want to change the base?
Allow for Custom Runtime Identifiers #97776
Conversation
The C# export process assigns a runtime identifier based off predefined options depending on the exporting platform and architecture. This makes sense almost all the time but I found a case where this creates a limitation. NativeAOT for android requires the linux-bionic-arm64 runtime identifier which is not what Godot assigns (it uses android-arm64). This can be solved by simply creating an override in the export settings for advanced users that want to try a custom runtime identifier. The default functionality is untouched if the option is left blank.
For those interested in getting With that, here's what should be added to your Godot's
Of course, this is in addition to setting the target framework to Then, in the export settings for android (this is what this PR adds) go to the bottom under And if you set up the |
I don't think you should be able to override the runtime identifier. When exporting, Godot will use the template for the target platform and architectures, if you override the runtime identifier you may not match the template. For example, if you are exporting to Android but override the runtime identifier with And specifically about Android, since the runtime identifier also contains the architecture, if you override it with I would prefer a boolean option only available to Android exports to enable AOT which would automatically pick the correct runtime identifier (i.e.: pick |
I see what you mean, overriding the runtime identifier can open up the possibility of incompatible export settings. One reason I approached it this way is because it seemed unclear if in a future For your approach, since |
The C# export process assigns a runtime identifier based off predefined options depending on the exporting platform and architecture. This makes sense almost all the time but I found a case where this creates a limitation. NativeAOT for android requires the linux-bionic-arm64 runtime identifier which is not what Godot assigns (it uses android-arm64). This can be solved by simply creating an override in the export settings for advanced users that want to try a custom runtime identifier. The default functionality is untouched if the option is left blank.
Resolves #97775