Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve particles and VFX, add blob shadow below player and enemies #180

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 30, 2023

  • Add projector light textures.
  • Tweak the flying forklift's dynamic light and particles to be more noticeable.
  • Add bullet impact particles with collision against level geometry (using a generated SDF).
  • Don't use fixed FPS and disable interpolation to make particles smoother (trails aren't used, so fixed FPS isn't strictly needed).
  • Add proximity fade to some particles to smooth out the transition with solid geometry.
  • Fix some particles being shaded when they should be unshaded.
  • Reduce crosshair size to be more subtle while aiming.

Preview

Videos:

- Add projector light textures.
- Tweak the flying forklift's dynamic light and particles to be more noticeable.
- Add bullet impact particles with collision against level geometry
  (using a generated SDF).
- Don't use fixed FPS and disable interpolation to make particles smoother
  (trails aren't used, so fixed FPS isn't strictly needed).
- Add proximity fade to some particles to smooth out the transition
  with solid geometry.
- Fix some particles being shaded when they should be unshaded.
- Reduce crosshair size to be more subtle while aiming.
@akien-mga
Copy link
Member

akien-mga commented Dec 1, 2023

Tested locally, it looks really cool! Thanks for working on these VFX, I felt they could use another pass for a long time.

There are two VFX which I think would still warrant more work, but that could be done in another PR;

  • The robot enemy shot animation feels very underwhelming IMO, and there's also a position bug where the explosion happens on the robot instead of where it shoots.
Screencast.2023-12-01.11.22.45_v2.mp4

Edit: GH doesn't like my encoding, but the video plays ok with mplayer or ffplay when downloaded. I've been struggling to get a proper recording with SimpleScreenRecorded today so fell back to old Kazam which might not be using state of the art formats.

See the 3.x version of the TPS demo (at least as it was some time ago):
tps-demo-aces-fitted

This was maybe lost during the conversion to Godot 4? The right amount of detail is maybe somewhere in between, but I do feel that having more activity that breaks from the pure spherical and almost flat shaded orb could be nice.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@QbieShay
Copy link
Contributor

QbieShay commented Dec 1, 2023

RE: Sun flare

I think I had some WIP for a fancier orb, but im not sure if i ended up pushing it upstream or not

RE: VFX

Feel free to improve them! Those were one of the first VFX I did when i started my VFX career, they can definitely use some improvement (especially those light shafts that I made in the past are a bit ... uuuuuhhh)

@Calinou Calinou merged commit 241b450 into godotengine:master Dec 1, 2023
1 check passed
@Calinou Calinou deleted the improve-particles branch December 1, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants