Add Oracle Coherence storage driver

[tmiddlet2666]

This pull request aims to add Coherence implementation into storage.
Thanks for the review, Please let me know of any issues to resolve.

[gaby]

@tmiddlet2666 Thanks for the PR, lets us know when its ready for review

[tmiddlet2666]

@tmiddlet2666 Thanks for the PR, lets us know when its ready for review

Thanks, not sure why the test is vailing on downloading our coherence-ce image https://github.com/gofiber/storage/actions/runs/5804095386/job/15734559701?pr=920

Getting Error: Process completed with exit code 56.

The image is around 257MB, so reasonably large. Are there any limits on disk or downloads?

[gaby]

@tmiddlet2666 Thanks for the PR, lets us know when its ready for review

Thanks, not sure why the test is vailing on downloading our coherence-ce image https://github.com/gofiber/storage/actions/runs/5804095386/job/15734559701?pr=920

Getting Error: Process completed with exit code 56.

The image is around 257MB, so reasonably large. Are there any limits on disk or downloads?

250MB is not large by any means. The problem is something on that health/start script. Have you tried running that shell code locally?

[gaby]

Adding TLS issue for refenrece here: oracle/coherence-go-client#47

@tmiddlet2666 Overall it looks good so far, do you want to add go1.21 to the CI now that it was released yesterday?

[tmiddlet2666]

Thanks @gaby
I have added the Config options and currently they set env variables, but when the above issue in coherence-go-client is fixed and released, i can update this package.
Will add go 1.21.

[gaby]

Thanks @gaby I have added the Config options and currently they set env variables, but when the above issue in coherence-go-client is fixed and released, i can update this package. Will add go 1.21.

For reference for the Redis driver, we allow the user to provide a tls.Config object. That way they can customize it to their needs.

https://github.com/gofiber/storage/blob/main/redis/redis.go#L50C4-L50C4

Example:

// Create a client with support for TLS
cer, err := tls.LoadX509KeyPair("./client.crt", "./client.key")
if err != nil {
	log.Println(err)
	return
}
tlsCfg := &tls.Config{
	MinVersion:               tls.VersionTLS12,
	InsecureSkipVerify:       true,
	Certificates:             []tls.Certificate{cer},
}

[tmiddlet2666]

@gaby - have moved from pending to proper PR

[gaby]

@gaby - have moved from pending to proper PR

Thanks for the contribution, will start reviewing this week. So far it looks good.

[gaby]

lgtm, thank you!

[ReneWerner87]

@tmiddlet2666 @gaby

what is the best thing to do in this case?

[gaby]

@tmiddlet2666 @gaby what is the best thing to do in this case?

It was passing fine, and with the last gosec/go update it now gets flag.

@tmiddlet2666 We may need this to be solved: oracle/coherence-go-client#49

[tmiddlet2666]

@tmiddlet2666 @gaby what is the best thing to do in this case?

Let me work on adding the *tls.Config support.
I'll need to release a new go client.
will take me a couple of days and i'll ping you.
Thanks

[gaby]

@tmiddlet2666 @gaby what is the best thing to do in this case?

Let me work on adding the *tls.Config support. I'll need to release a new go client. will take me a couple of days and i'll ping you. Thanks

Sounds like a plan, thank you!