-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ New PUBSUB - NATS JetStream support #1002
base: development
Are you sure you want to change the base?
✨ New PUBSUB - NATS JetStream support #1002
Conversation
Hey, could you please check this out It is mentioned to have a separate repo - but you can also create a separate package, the same way it is done for mongodb, cassandra... this should be supported as an external package - such that users who are using it will only have it in the binary. |
Hey @mfreeman451, I think the issue is with line 38 in Also, you are introducing the packages
Not there are 2 things you could do -
|
The separate |
@mfreeman451 I understand how we need to declare new modules for the new integrations(such as they are not a direct dependency in the applications that are not using it). You can check #1054, container package to see how @aryanmehrotra implemented Azure EventHub as an external pubsub dependency. |
Anything else left to do here? |
@mfreeman451 your PR is passing all the tests but failing the code quality step. Here's what i found when i looked into it: Please resolve these issues. |
Pull Request Template
Description:
Breaking Changes (if applicable):
N/A
Additional Information:
Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!