Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Improper-sqlite-logs #1057

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Sep 27, 2024

Screenshot 2024-09-27 at 12 13 53 PM

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

pkg/gofr/datasource/sql/sql_test.go Outdated Show resolved Hide resolved
examples/http-server/configs/.env Outdated Show resolved Hide resolved
Umang01-hash
Umang01-hash previously approved these changes Sep 27, 2024
Copy link
Member

@vipul-rawat vipul-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this with the pretty print interface and using log struct, is that a feisable solution?
@aryanmehrotra

vipul-rawat
vipul-rawat previously approved these changes Sep 30, 2024
@Umang01-hash Umang01-hash merged commit 2074f0b into gofr-dev:development Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper logs in sqlite db
4 participants