Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace capital first letter for param and return names #165

Closed
dagood opened this issue Sep 4, 2024 · 1 comment
Closed

Replace capital first letter for param and return names #165

dagood opened this issue Sep 4, 2024 · 1 comment

Comments

@dagood
Copy link
Collaborator

dagood commented Sep 4, 2024

          nit: why CAPS for the `X` `Y` param names?

Originally posted by @derekparker in #135 (comment)

There are a decent number of existing names that can be cleaned up too--a few examples:

type BigInt
func GenerateKeyECDSA(curve string) (X, Y, D BigInt, err error)
func GenerateKeyRSA(bits int) (N, E, D, P, Q, Dp, Dq, Qinv BigInt, err error)

type PrivateKeyECDSA
func NewPrivateKeyECDSA(curve string, X, Y, D BigInt) (*PrivateKeyECDSA, error)

type PrivateKeyRSA
func NewPrivateKeyRSA(N, E, D, P, Q, Dp, Dq, Qinv BigInt) (*PrivateKeyRSA, error)

I've chalked this up to "spelling it how cryptographers do" in the past, so I'm indifferent, but we should probably decide.

@mertakman
Copy link
Collaborator

#172 solved this, please close this issue

@qmuntal qmuntal closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants