Fix AES-GCM decryption on OpenSSL 1.0.2-fips #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
force-pushed
the
fix-aes-gcm-102fips
branch
from
90b287c to
f8037de
Compare
corhere
force-pushed
the
fix-aes-gcm-102fips
branch
from
f8037de to
77785f2
Compare
Some of the standard library crypto/cipher AES-GCM tests fail when using OpenSSL 1.0.2 in FIPS mode, but pass with the same library when FIPS mode is disabled. Extend the AES-GCM tests to cover all the failure cases caught by the standard library tests and build the OpenSSL 1.0.2 library used in CI to be FIPS enabled. Link the OpenSSL 1.0.2 CI build against FIPS Object Module 2.0.1 rather than the latest version (2.0.16) as at least one commercially-supported FIPS validated build of OpenSSL 1.0.2 is known to use that version of the FIPS Object Module and some of the failures seen with 2.0.1 do not reproduce with 2.0.16. Signed-off-by: Cory Snider <csnider@mirantis.com>
Signed-off-by: Cory Snider <csnider@mirantis.com>
Include the OpenSSL error queue in the returned error. Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
fix-aes-gcm-102fips
branch
2 times, most recently
from
527e37f to
7bb4f4b
Compare
corhere
force-pushed
the
fix-aes-gcm-102fips
branch
from
7bb4f4b to
eb456ec
Compare
which replaces func version1_1_1_or_above(). Signed-off-by: Cory Snider <csnider@mirantis.com>
OpenSSL 1.0.2 FIPS mode will claim to support the aforementioned algorithms but will fail with the error "disabled for fips" when one tries to initialize an EVP context with one. Signed-off-by: Cory Snider <csnider@mirantis.com>
This lets the compiler statically prove e.g. vPatch >= 0 is a constant so it can optimize away unnecessary comparisons after inlining and constant-propagating calls to versionAtOrAbove(). Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
fix-aes-gcm-102fips
branch
from
eb456ec to
9b5d63e
Compare
qmuntal
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the standard library crypto/cipher AES-GCM tests fail when using OpenSSL 1.0.2 in FIPS mode, but pass with the same library when FIPS mode is disabled. Extend the AES-GCM tests to cover all the failure cases caught by the standard library tests, build OpenSSL 1.0.2 in CI to be FIPS-enabled, and update the bindings so the tests pass.