Support Ed25519 #114
Merged
Support Ed25519 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
force-pushed
the
ed25519
branch
2 times, most recently
from
02f693d to
b56a21f
Compare
qmuntal
requested review from
ueno,
derekparker,
simo5,
dagood and
dbenoit17
dagood
reviewed
Sep 1, 2023
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
dagood
approved these changes
Sep 5, 2023
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
|
@ueno @derekparker PTAL |
|
@derekparker @ueno I'll be taking a long leave soon and I'll like to have this PR as ready as possible to be merged. Could you take a look? Thanks! |
ueno
reviewed
Oct 12, 2023
ed25519.go
Outdated
| } | ||
|
|
||
| // SignEd25519 signs the message with priv and returns a signature. | ||
| func SignEd25519(priv, message []byte) (sig []byte, err error) { |
There was a problem hiding this comment.
Unlike ECDSA, this API takes a private key as bytes and internally reconstructs the corresponding EVP_PKEY, which I suspect would prevent using non-extractable keys such as ones on PKCS#11. Why not defining a dedicated key type around EVP_PKEY, like PrivateKeyECDSA?
There was a problem hiding this comment.
Good point. I've updated the implementation to use PrivateKeyEd25519 and PublicKeyEd25519 instead of raw byte slices.
ueno
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ed25519.
OpenSSL still doesn't support Ed25519ctx nor Ed25519ph, so these are not added.
New APIs: