rsa: Allow omission of precomputed values in NewPrivateKeyRSA #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested changes
Feb 13, 2024
OpenSSL 3.0 and 3.1 required precomputed values for CRT (Dp, Dq, and Qinv), when the primes (P and Q) are included in the params array. Since all of them can be derived from N, E, and D, this patch simply stops passing those values if any of them are missing. See also: openssl/openssl#22334 Signed-off-by: Daiki Ueno <dueno@redhat.com>
ueno
force-pushed
the
wip/rsa-omit-crt-params
branch
from
a9c1bdf to
e417598
Compare
qmuntal
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.0 and 3.1 required precomputed values for CRT (Dp, Dq, and Qinv), when the primes (P and Q) are included in the params array.
Since all of them can be derived from N, E, and D, this patch simply stops passing those values if any of them are missing.
See also: openssl/openssl#22334