Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build tag excluding thread_setup.go during bootstrap #137

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add build tag excluding thread_setup.go during bootstrap #137

merged 1 commit into from
Feb 21, 2024

Conversation

derekparker
Copy link
Contributor

@derekparker derekparker commented Feb 16, 2024 •
edited
Loading

This file utilizes CGO which causes the bootstrap phase of the compiler build to fail.

@derekparker derekparker mentioned this pull request Feb 16, 2024
Merged
@jonjohnsonjr
Copy link

Is there anything blocking this from being merged?

dbenoit17
dbenoit17 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@dbenoit17 dbenoit17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dagood
dagood approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to mention why this is necessary in the PR desc or commit. No objection to the change itself though.

@derekparker
Copy link
Contributor Author

It would be nice to mention why this is necessary in the PR desc or commit. No objection to the change itself though.

Added a quick description.

@derekparker derekparker merged commit 576fe0d into golang-fips:v2 Feb 21, 2024
8 checks passed
@derekparker derekparker deleted the fix-bootstrap branch February 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbenoit17 dbenoit17 dbenoit17 approved these changes

@dagood dagood dagood approved these changes

@qmuntal qmuntal qmuntal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derekparker @jonjohnsonjr @qmuntal @dagood @dbenoit17