Only omit RSA primes if precomputed values are missing in OpenSSL 3.0 and 3.1 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
changed the title
karianna
reviewed
Sep 4, 2024
dagood
reviewed
Sep 5, 2024
Good point. I've added some tests and, while here, improved a bit all the RSA tests. |
karianna
approved these changes
Sep 5, 2024
dagood
approved these changes
Sep 6, 2024
|
@qmuntal will need a rebase now |
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
|
@ueno can you take a look at this? Thanks. |
mertakman
pushed a commit
to mertakman/openssl
that referenced
this pull request
Sep 10, 2024
… and 3.1 (golang-fips#163) * only allow omission of precomputed RSA values in OpenSSL 3.0 and 3.1 * check if rsa primes and precomputed values exists * make logic more clear * Update rsa.go Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> * add tests * exhaustively tests messing precomputed values --------- Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenSSL 3.2, RSA primes can coexist with empty precomputed values, see openssl/openssl#22334.
Some providers, such as SymCrypt, compute the RSA private key using the prime numbers
PandQinstead of loading it from the private exponentD. So they always needPandQ, even if the precomputed values are omitted. This means that these providers are not fully compatible with OpenSSL 3.0 and 3.1, but they do work with OpenSSL 3.2 and higher.This PR relaxes the restriction added in #136 to only take effect with OpenSSL 3.0 and 3.1.