-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate ECDH keys #226
Merged
Validate ECDH keys #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
ueno,
karianna,
derekparker,
dagood,
mertakman and
gdams
November 26, 2024 10:12
mertakman
reviewed
Nov 26, 2024
mertakman
approved these changes
Nov 26, 2024
dagood
approved these changes
Nov 26, 2024
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
gdams
approved these changes
Dec 3, 2024
dagood
approved these changes
Dec 3, 2024
@derekparker the fix in this PR is blocking our upstream sync process. Could you take a look? Thanks. |
For microsoft/go#1416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.24 removed some ECDH key checks from the
crypto/ecdh
package and moved them tocrypto/internal/fips/ecdh
: golang/go@566cf1c#diff-e9f4458b20e24935551d73dc6b34e4007d91ca35e1e2c5b4d1e9f2a738d04e9cL79.This means that the checks are no longer run in the the crypto backend layer, so we must instruct OpenSSL to perform that checks.
golang/go@566cf1c also refactored the ECDH implementation so that
ecdh.PrivateKey.Public
is no longer lazy loaded, but generated whenecdh.NewPrivateKey
is called. Following suite here, as it simplifies our implementation and makes key validation easier.