[ms-go1.22-support] Support MD5SHA1 in PKCS1 v1.5 signatures #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1246bfd)
qmuntal
force-pushed
the
msgo1.22-md5sha1
branch
from
06597a9 to
6b0b5f0
Compare
gdams
changed the title
gdams
approved these changes
Nov 26, 2024
dagood
approved these changes
Nov 26, 2024
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
|
Not sure if this worth backporting, as triggering this issue using the Go 1.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymCrypt added support for using MD5SHA1 in PKCS1 v1.5 signatures, but we don't handle it correctly. This PR special case MD5SHA1 so it is used even when EVP_MD_fetch says it is not supported.