Support more hash types in RSA PKCS1v15 and PSS #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
karianna,
derekparker,
dagood,
mertakman and
gdams
dagood
approved these changes
Dec 17, 2024
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
gdams
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the supported hash types, as reported by
openssl.SupportsHash, to increase the compatibility of the RSA PCKS1v15 and PSS sign and verify functions with the standard library. It is now possible to use those algorithms withcrypto.RIPEMD160,crypto.SHA512_224andcrypto.SHA512_256, if the OpenSSL provider (or legacy engine) supports it.While here, clean up
cryptoHashToMDandSupportsHash. The former doesn't need to check if the given hash is supported or not.