Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candishared: add method to set multiple context on event context #36

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

harissudrajat
Copy link
Contributor

No description provided.

Copy link
Member

@agungdwiprasetyo agungdwiprasetyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (96726bc) 18.66% compared to head (d346605) 18.87%.
Report is 1 commits behind head on master.

❗ Current head d346605 differs from pull request most recent head 9d36628. Consider uploading reports for the commit 9d36628 to get more accurate results

Files Patch % Lines
candishared/event_context.go 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   18.66%   18.87%   +0.21%     
==========================================
  Files          41       41              
  Lines        2454     2458       +4     
==========================================
+ Hits          458      464       +6     
+ Misses       1981     1978       -3     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agungdwiprasetyo agungdwiprasetyo merged commit 5373d19 into golangid:master Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants