Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrade JWT version to v5 due to CVE-2024-51744 #54

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

isogram
Copy link
Collaborator

@isogram isogram commented Nov 18, 2024

image

Due to a security concern raised in CVE-2024-51744 and the outdatedness of the JWT library version, we need to update our JWT version to the latest one to ensure the application's security. This PR makes the necessary adjustments.

I am unsure if these changes will break the application, so I would appreciate it if you could review them
@golangid/candi-reviewer.

Additionally, please refer to the migration guide for any related changes.

@isogram isogram requested a review from a team as a code owner November 18, 2024 07:23
@isogram isogram added the dependencies Pull requests that update a dependency file label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.30%. Comparing base (44080aa) to head (b30326f).
Report is 2 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development      #54   +/-   ##
============================================
  Coverage        17.30%   17.30%           
============================================
  Files               54       54           
  Lines             4161     4161           
============================================
  Hits               720      720           
  Misses            3416     3416           
  Partials            25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@agungdwiprasetyo agungdwiprasetyo changed the base branch from master to development November 18, 2024 16:28
Copy link
Member

@agungdwiprasetyo agungdwiprasetyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agungdwiprasetyo agungdwiprasetyo merged commit df4b2be into golangid:development Nov 18, 2024
3 checks passed
@agungdwiprasetyo
Copy link
Member

baru baca ini https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md, ternyata major juga changesnya ya 😂

@willy182
Copy link
Collaborator

@isogram
Copy link
Collaborator Author

isogram commented Dec 14, 2024

Major disisi JWT nya. Dari app yg make Candi harusnya ga begitu besar. Tergantung dari cara App nya handle JWT nya juga sih.

Cuma ganti nama attribute harusnya.

@willy182 masih di development keknya blm masuk ke main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants