-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: upgrade JWT version to v5 due to CVE-2024-51744 #54
dependencies: upgrade JWT version to v5 due to CVE-2024-51744 #54
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #54 +/- ##
============================================
Coverage 17.30% 17.30%
============================================
Files 54 54
Lines 4161 4161
============================================
Hits 720 720
Misses 3416 3416
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
baru baca ini https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md, ternyata major juga changesnya ya 😂 |
lu revert lagi yak @agungdwiprasetyo ? https://github.com/golangid/candi/blob/v1.18.5/candishared/token_claim_payload.go#L7 |
Major disisi JWT nya. Dari app yg make Candi harusnya ga begitu besar. Tergantung dari cara App nya handle JWT nya juga sih. Cuma ganti nama attribute harusnya. @willy182 masih di development keknya blm masuk ke main. |
Due to a security concern raised in CVE-2024-51744 and the outdatedness of the JWT library version, we need to update our JWT version to the latest one to ensure the application's security. This PR makes the necessary adjustments.
I am unsure if these changes will break the application, so I would appreciate it if you could review them
@golangid/candi-reviewer.
Additionally, please refer to the migration guide for any related changes.