Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change opentracing to opentelemetry for tracing #56

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

agungdwiprasetyo
Copy link
Member

@agungdwiprasetyo agungdwiprasetyo commented Dec 25, 2024

for existing service, only change jaeger host from 5775 (udp) to 4317 (latest jaeger version, using grpc exporter) without changing the code

test result:
image

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 17.21%. Comparing base (2f24be2) to head (53aedc1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tracer/jaeger.go 0.00% 63 Missing ⚠️
tracer/utils.go 0.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   17.24%   17.21%   -0.03%     
==========================================
  Files          54       54              
  Lines        4176     4183       +7     
==========================================
  Hits          720      720              
- Misses       3431     3438       +7     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agungdwiprasetyo agungdwiprasetyo merged commit 2f6a237 into golangid:master Dec 30, 2024
1 of 3 checks passed
@agungdwiprasetyo agungdwiprasetyo deleted the otel branch December 30, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant