Skip to content

Commit

Permalink
Merge branch 'main' into gcp-cache-poison
Browse files Browse the repository at this point in the history
  • Loading branch information
matt0x6F authored Jun 2, 2024
2 parents 4ac9013 + c1891f1 commit 57e0605
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ test-unit-docker: ## run unit tests with docker

.PHONY: test-e2e
test-e2e:
cd e2etests && go test --tags e2etests
./scripts/test_e2e.sh

.PHONY: test-e2e-docker
test-e2e-docker:
Expand Down
4 changes: 0 additions & 4 deletions pkg/storage/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Co
return nil, errors.E(op, err)
}

// Remove anonymous credentials from the default config so that
// session.NewSession can auto-resolve credentials from role, profile, env etc.
awsConfig.Credentials = nil

for _, o := range options {
o(&awsConfig)
}
Expand Down
7 changes: 7 additions & 0 deletions scripts/test_e2e.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash

# test_e2e.sh

# Run the e2e tests with the race detector enabled
set -xeuo pipefail
cd e2etests && go test --tags e2etests -race

0 comments on commit 57e0605

Please sign in to comment.