Fixed "make test-e2e-docker" #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-e2e-docker'.
joeymhills
changed the title
matt0x6F
approved these changes
Jun 2, 2024
|
@joeymhills Thank you for your contribution to Athens! |
matt0x6F
referenced
this pull request
in gomods/athens-charts
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gomods/athens](https://togithub.com/gomods/athens) | patch | `v0.14.0` -> `v0.14.1` | --- ### Release Notes <details> <summary>gomods/athens (gomods/athens)</summary> ### [`v0.14.1`](https://togithub.com/gomods/athens/releases/tag/v0.14.1) [Compare Source](https://togithub.com/gomods/athens/compare/v0.14.0...v0.14.1) #### What's Changed - CI dependency updates in [https://github.com/gomods/athens/pull/1962](https://togithub.com/gomods/athens/pull/1962) - Fix for AWS default credentials by [@​yongzhang](https://togithub.com/yongzhang) in [https://github.com/gomods/athens/pull/1963](https://togithub.com/gomods/athens/pull/1963) - Fix for E2E test runs by [@​joeymhills](https://togithub.com/joeymhills) in [https://github.com/gomods/athens/pull/1966](https://togithub.com/gomods/athens/pull/1966) - Feature gcp/saver: Only return errors.KindAlreadyExists if all three exist by [@​dwbuiten](https://togithub.com/dwbuiten) in [https://github.com/gomods/athens/pull/1957](https://togithub.com/gomods/athens/pull/1957) - Fix to set correct content type and send only once by [@​matt0x6F](https://togithub.com/matt0x6F) in [https://github.com/gomods/athens/pull/1965](https://togithub.com/gomods/athens/pull/1965) #### New Contributors - [@​yongzhang](https://togithub.com/yongzhang) made their first contribution in [https://github.com/gomods/athens/pull/1963](https://togithub.com/gomods/athens/pull/1963) - [@​joeymhills](https://togithub.com/joeymhills) made their first contribution in [https://github.com/gomods/athens/pull/1966](https://togithub.com/gomods/athens/pull/1966) - [@​dwbuiten](https://togithub.com/dwbuiten) made their first contribution in [https://github.com/gomods/athens/pull/1957](https://togithub.com/gomods/athens/pull/1957) **Full Changelog**: gomods/athens@v0.14.0...v0.14.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/gomods/athens-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Of course! happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Fixes issue #1947 where
make test-e2e-dockerfails from callingscripts/test_e2e.sh, which does not exist.How is the fix applied?
created
scripts/test_e2e.shwhich allows us to run the e2e tests in docker compose. I also modified the Makefile to use this script inmake test-e2efor readability and consistency withmake test-unitWhat GitHub issue(s) does this PR fix or close?
Fixes #1947