Document log level format #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ullaakut
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you @raxod502-plaid for your contribution!
Unfortunately like I explain in my comment, I would rather not merge this, but if someone thinks it's relevant, I wouldn't oppose it. If no one reaches out within a few days I'll close the PR.
matt0x6F
approved these changes
Sep 28, 2024
Ullaakut
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation mentioned that log level could be customized via an environment variable, but didn't explain what values could be assigned to that environment variable. I looked at the source code to find out, and copied that information into the documentation.