Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swith s3 ListObjects api to ListObjectsV2 #2006

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

yatesliang
Copy link
Contributor

@yatesliang yatesliang commented Nov 18, 2024

What is the problem I am trying to address?

Swith the ListObjects API used in s3 storage to ListObjectsV2

How is the fix applied?

Change all ListObjects to ListObjectsV2 and also switch the input to ListObjectsV2Input

Note: field Marker in ListObjectsInput was renamed to StartAfter in ListObjectsV2Input

What GitHub issue(s) does this PR fix or close?

Fixes #1991

@yatesliang yatesliang requested a review from a team as a code owner November 18, 2024 03:07
Copy link
Contributor

@matt0x6F matt0x6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm not seeing where the old AWS SDK was removed though; do we need to run go mod tidy or do we have other usages?

@matt0x6F matt0x6F enabled auto-merge (squash) November 26, 2024 03:00
@matt0x6F matt0x6F merged commit 8f0ee5e into gomods:main Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ListObjectsV2
2 participants