Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes img/sec/core. #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes img/sec/core. #280

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Aug 10, 2023

Fixes img/sec/core.

Before this fix, only lt0 but not lstep was updated after computing an evaluation, which led to a img/sec/core computation that was too high. Tis fix simply adds the time needed to eval / checkpoint to lt0, correcting the dt term in the dsteps/dt computation.

@copybara-service copybara-service bot force-pushed the test_555396130 branch 2 times, most recently from 6e76888 to ebbd1f2 Compare August 10, 2023 09:56
Before this fix, only `lt0` but not `lstep` was updated after computing an evaluation, which led to a img/sec/core computation that was too high. Tis fix simply adds the time needed to eval / checkpoint to `lt0`, correcting the `dt` term in the `dsteps/dt` computation.

PiperOrigin-RevId: 555396130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant