Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine online CPUs from a standard source. #3318

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented May 30, 2023

Determine CPUs that are online from /sys/devices/system/cpu/online compared to the path generated from the parameters, which may not exist.

I'm really looking forward to any suggestions or insights from the community.

Addresses: #3317

@google-cla
Copy link

google-cla bot commented May 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @kishen-v. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kishen-v kishen-v marked this pull request as draft May 30, 2023 06:44
@kishen-v
Copy link
Contributor Author

/cc @mkumatag

@kishen-v kishen-v force-pushed the cpupath-fixes branch 4 times, most recently from f26375c to 0d70112 Compare June 6, 2023 06:11
@kishen-v kishen-v marked this pull request as ready for review June 6, 2023 06:13
@iwankgb
Copy link
Collaborator

iwankgb commented Jun 7, 2023

/ok-to-test

@mkumatag
Copy link
Contributor

mkumatag commented Jun 8, 2023

I see failures with following reason:

I0608 01:18:34.352] I0608 01:17:51.377898    1741 framework.go:334] About to run - [sudo docker run -d --name test-basic-docker-container-1741 kubernetes/pause]
I0608 01:18:34.352]     framework.go:337: Failed to run "sudo" [docker run -d --name test-basic-docker-container-1741 kubernetes/pause] in "localhost" with error: "exit status 125". Stdout: "", Stderr: Unable to find image 'kubernetes/pause:latest' locally
I0608 01:18:34.352]         docker: Error response from daemon: manifest for kubernetes/pause:latest not found: manifest unknown: manifest unknown.
I0608 01:18:34.352]         See 'docker run --help'.

kubernetes/pause doesn't have any tags anymore

image

It will be better to adopt the newer image registry.k8s.io/pause

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 9, 2023

Fix is awaiting approval in #3304.

Signed-off-by: Kishen V <kishen.viswanathan@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants