-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flags typo #3327
Fix flags typo #3327
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @caiocfer. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
80707c3
to
0206b1a
Compare
/ok-to-test |
@caiocfer merge |
This has broke the build (or it was broken before as well now that the typo has been fixed):
|
Are you on a specific branch? Just tried to build and it went fine:
|
Found typo when building cAdvisor that was preventing Perf event metrics from being available.
And tags were passed to build as "-tags=-tags=libfpm,netgo,libipmctl".