-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s390/s390x CPU topology #3516
Conversation
Hi @madeelibm. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bobbypage We are adding support for s390x again with the PR: #3521 |
Can someone help to merge this PR? |
96992df
to
7872211
Compare
/ok-to-test |
@haircommander: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
you have some test failures that need fixing @madeelibm in the meantime @iwankgb @bobbypage PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides returning err instead of explicit nil in two places.
7872211
to
7ce7be1
Compare
/retest |
1 similar comment
/retest |
428a005
to
1929598
Compare
/retest |
All tests are passing now on x86 and Z. |
@iwankgb PTAL |
ff38143
to
3eb1be1
Compare
@madeelibm, can you merge |
12fafed
to
bd65768
Compare
/retest |
s390x CPU topology is missing in cadvisor which made kubelet service returns error when enabling CPU Manager. This patch adds missing CPU topology with which CPU Manager can also be enabled on s390x platform.
Please for review and if there are concerns let us know.