Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update very old test infra image #3527

Closed
wants to merge 4 commits into from

Conversation

bluestealth
Copy link

Copy link

google-cla bot commented May 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @bluestealth. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bluestealth bluestealth changed the title Update very old test infra image fix: update very old test infra image May 4, 2024
@akhilerm
Copy link
Contributor

akhilerm commented May 7, 2024

/cc @bobbypage

@akhilerm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Collaborator

@akhilerm: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iwankgb
Copy link
Collaborator

iwankgb commented May 20, 2024

/ok-to-test

@iwankgb iwankgb closed this May 26, 2024
@iwankgb iwankgb reopened this May 26, 2024
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Collaborator

dims commented Jun 19, 2024

/retest

@@ -58,12 +58,12 @@ function run_tests() {
--privileged \
--cap-add="sys_admin" \
--entrypoint="" \
gcr.io/k8s-testimages/bootstrap \
gcr.io/k8s-staging-test-infra/bootstrap \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: You're going to have to switch this again soon when we move to artifact registry for staging images, and this image is also considered deprecated ...

@bobbypage
Copy link
Collaborator

#3540 was merged which updates the image used as well.

@bluestealth
Copy link
Author

Given #3540 is merged feel free to close

@bobbypage
Copy link
Collaborator

Given #3540 is merged feel free to close

Thank you for your help here!

@bobbypage bobbypage closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants