Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using bookworm images #3540

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Using bookworm images #3540

merged 3 commits into from
Jun 21, 2024

Conversation

iwankgb
Copy link
Collaborator

@iwankgb iwankgb commented Jun 15, 2024 •
edited
Loading

Fixing images:

  • Using community one instead of Google one.
  • Using Debian Bookworm Go image
  • Upgrading libipmctl4 to libipmctl5
  • Using Ubuntu 22.04 GH runners

@iwankgb
Copy link
Collaborator Author

iwankgb commented Jun 15, 2024

It must be merged to fix failing build in #3516.

@iwankgb iwankgb force-pushed the bookworm branch 2 times, most recently from bcabb0a to 41e740f Compare June 15, 2024 17:08
@iwankgb
Copy link
Collaborator Author

iwankgb commented Jun 15, 2024

@bobbypage, you'll need to change required checks, I believe.

@iwankgb iwankgb requested a review from bobbypage June 15, 2024 17:28
dims
dims approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbypage
Copy link
Collaborator

Thanks!

@bobbypage bobbypage merged commit ca6468b into google:master Jun 21, 2024
14 checks passed
@bobbypage
Copy link
Collaborator

Updated the checks as well to 22.04:

image

@bobbypage bobbypage mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwankgb @bobbypage @dims