-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fixes error thrown when using charts in page- or tabview #452
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good!
Apparently someone is needed who has the necessary write access. Can someone approve this fix please? |
There is a fork of charts at exafree/charts_cf that accepts pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this solved our memory leak bug on dispose()
This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue. |
As mentioned in #277 the BaseChartState throws an error when skipping over in a page- or tabview. I've implemented the check as mentioned in the pull request and that fixes the problem.