-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix warnings for Flutter 3.0 - Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
#765
Conversation
@fzyzcjy one more file need to be fix https://github.com/google/charts/blob/master/charts_flutter/example/lib/behaviors/slider.dart |
done |
must be specify limit new flutter version 3.0.0 in pubspec.yml otherwise those who are not using latest version of 3.0.0, they all are getting error. #764 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain compatibility while removing warnings, I would recommend using the approach suggested in the Flutter 3.0 release notes: https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0#your-code
@rickcasson can you close this pr? Bcz @fzyzcjy might be not available and assign me . |
Oh I forgot it. Let me update it. |
done |
Fix #771 |
Any updates...? |
Hey @rickcasson, any idea when it would be released? Thanks ;) |
@lohanbodevan @fzyzcjy, sorry, no idea. I'm not a maintainer of this repo, and based on the readme, it doesn't sound like they are accepting external contributions anyway... |
@google-admin , @google-ospo-team , gentle bump |
@google/google-charts-admins can maybe help |
Same issue |
Did anyone find any other solution for this? @google-admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome, comments are clear. Would be nice if this got approved
Would be nice if this got approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is OK
@nshahan can you please look into it? Thank you. |
@rickcasson when this branch gets merged |
+1 for this, this is the last package my app needs to be updated for Flutter 3+ |
@DanOxlade you can already upgrade to Flutter 3+. The library does its job, the only annoying thing is a little warning (not error, see PR description) you will get every time you will build an app. |
pr is fine, what is the issue? |
This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue. |
Detailed warnings:
fix #771