misc updates to the repo readme #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @craiglabenz |
|
craiglabenz
reviewed
May 16, 2024
| <td align="center"><img height="16" width="16" src="https://raw.githubusercontent.com/google/flutter-mediapipe/main/assets/no.png"/></td> | ||
| <td align="center">✅</td> | ||
| <td align="center">✅</td> | ||
| <td align="center">-</td> |
There was a problem hiding this comment.
Does a red emoji make sense here instead of a single dash?
There was a problem hiding this comment.
I tend to think of an unfilled square as more 'missing' rather than an error state, but this is your readme :) I can try that out something like ❌ or ✖.
There was a problem hiding this comment.
Hmm, that's a good point. We can go with -.
craiglabenz
reviewed
May 16, 2024
| | [mediapipe_core](packages/mediapipe-core/) | Shared logic and utilities required by other MediaPipe Task packages. | 0.0.1 | | ||
| | [mediapipe_text](packages/mediapipe-task-text/) | An implementation of the MediaPipe Text APIs | 0.0.1 | | ||
| | [mediapipe_genai](packages/mediapipe-task-genai/) | An implementation of the MediaPipe GenAI APIs | 0.0.1 | | ||
| | [mediapipe_core](packages/mediapipe-core/) | Shared logic and utilities required by other MediaPipe Task packages. |  | |
craiglabenz
approved these changes
May 19, 2024
|
Thanks for the review! FYI that I'm unable to land this PR myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc updates to the repo readme:
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?