Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foldit: Version 1.003 added #5361

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Foldit: Version 1.003 added #5361

merged 3 commits into from
Oct 6, 2022

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Oct 3, 2022

2820c7c: [gftools-packager] Foldit: Version 1.003 added

Closes #5093

@gf-bot
Copy link

gf-bot commented Oct 3, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[17] Foldit[wght].ttf
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Thin' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:257]
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Sophia Tai is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • uni004A0301

    • And uni006A0301
      [code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/foldit/Foldit[wght].ttf
Dehinted Size 508.3kb
Hinted Size 508.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.003"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/foldit [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 8 51 9 158 0
0% 0% 4% 22% 4% 70% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Oct 5, 2022

Thanks. I'll upload the designers details after lunch in a new pr.

We also need to keep this PR blocked until the latest version of Chrome is out.

@vv-monsalve
Copy link
Collaborator

Thanks. I'll upload the designers details after lunch in a new pr.

I've sent an email to the designer so that she can provide an image for her profile. I'll create a PR with her information after that.

@RosaWagner RosaWagner merged commit a967eba into main Oct 6, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_foldit branch October 6, 2022 14:02
@emmamarichal
Copy link
Collaborator

@vv-monsalve, sorry I hadn't seen your comment, and I sent a message on instagram to the author. She just added her avatar to the folder. 👌 I can do it if you want, unless you've already started.

@RosaWagner
Copy link
Contributor

@m4rc1e @vv-monsalve writing here what Rod reported in the chat; the font needs to go through the color script again (missing SVG table)

@vv-monsalve
Copy link
Collaborator

@vv-monsalve, sorry I hadn't seen your comment, and I sent a message on instagram to the author. She just added her avatar to the folder. 👌 I can do it if you want, unless you've already started.

Ah, ok, she didn't reply to my email so I haven't started it. If she has provided the image now, yes please you could add her bio ingo if that's ok for you. Thanks

@vv-monsalve
Copy link
Collaborator

@m4rc1e @vv-monsalve writing here what Rod reported in the chat; the font needs to go through the color script again (missing SVG table)

@m4rc1e Is that something we should do it independently (post-process) or is it already included in fontmake and then cutting a new release would be enough to cover it?

@vv-monsalve
Copy link
Collaborator

@anthrotype
Copy link
Member

just to clarify once again, "support for variations of gradients" does not mean that the SVG table converted from COLRv1 will contain variations (that's unsupported in the format), simply means maximum_color will henceforth ignore variation data in COLR table when generating the SVG table which will then only contain paths/gradients from the default VF instance.

@anthrotype
Copy link
Member

@vv-monsalve @m4rc1e I'm working on it right now. Note that since we drop all variations and only leave the default instance in the SVG, the Thin weight will be displayed for those environments that only support OT-SVG and not COLRv1 (e.g. Safari/FireFox, macOS, iOS, Adobe apps etc.). E.g. this is the Finder preview on macOS:

Screen Shot 2022-10-14 at 11 39 16

If you wanted a more "regular" weight to be shown by default you'd have to change the default master to be the Regular (if there's one, haven't looked at your source). If you are fine with it, never mind ignore my comment.

@anthrotype
Copy link
Member

/cc @SophiaDesign

@anthrotype
Copy link
Member

FYI googlefonts/nanoemoji#439

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Oct 14, 2022

Thanks for the expanded clarification @anthrotype.

simply means maximum_color will henceforth ignore variation data in COLR table when generating the SVG table which will then only contain paths/gradients from the default VF instance

Would it mean that the same gradients would be used for the wider-bolder instances? As Dave said in one comment of the issues:

is a new variable color font that makes extensive use of color variations (amusingly in a way to create the illusion that as the weight (and natural width) changes, the gradients look like they don't change, which requires them TO change

So, would that effect be lost in the resulting VF if the SVG table will contain only the gradients of the font origin?

Thin weight will be displayed for those environments that only support OT-SVG and not COLRv1 (e.g. Safari/FireFox, macOS, iOS, Adobe apps etc.)

I don't think this is an issue.

@anthrotype
Copy link
Member

Would it mean that the same gradients would be used for the wider-bolder instances?

yes - not just the gradient geometries, the shapes themselves will not vary, SVG simply can't encode OT variations. The rest of the font may be variable, and that's actually a problem because if you select anything other than the Thin instance it will look wrong (outlines of the thin, too wide metrics for the selected non-Thin instance). see googlefonts/nanoemoji#439 (comment)

@SophiaDesign
Copy link

If you wanted a more "regular" weight to be shown by default you'd have to change the default master to be the Regular (if there's one, haven't looked at your source). If you are fine with it, never mind ignore my comment.

There is no Regular master in the source file. It was removed to minimise the file size. Can be added easily if preferred?

@vv-monsalve
Copy link
Collaborator

There is no Regular master in the source file. It was removed to minimise the file size. Can be added easily if preferred?

I think this isn't needed because of the reasons provided on the related issues and Marc's comment in the above issue.

To my understanding, when he says that is better to leave the font as is this implies:

  • Not to run the maximum_color (so we wouldn't have the hybrid COLRv1+SVG when the COLR table contains variations since a B/N VF is preferable rather than having only the SVG of the font origin)
  • We release it with a note to users in the description file
  • Should we still wait for the latest version of Chrome?
  • Would it be something else be necessary?

cc @m4rc1e, @chrissimpkins, @davelab6

@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Jan 27, 2023

This family remains blocked for technical reasons and should not be moved beyond dev until further notice. It is appropriately labeled blocked.

@RosaWagner RosaWagner added --- to production --- Live Font is visible on API and removed --- blocked labels Apr 26, 2023
@RosaWagner RosaWagner removed the --- Live Font is visible on API label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Foldit
8 participants