Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): rework ucontext_t introspection #954

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Oct 5, 2023

Fixes #953

@cieplik Does this work for you?

@sergiud sergiud added the bug label Oct 5, 2023
@sergiud sergiud added this to the 0.7 milestone Oct 5, 2023
@cieplik
Copy link

cieplik commented Oct 6, 2023

Fixes #953

@cieplik Does this work for you?

@sergiud, thank you for the PR, I'll check it early next week and will let you know.

@cieplik
Copy link

cieplik commented Oct 9, 2023

Fixes #953
@cieplik Does this work for you?

@sergiud, thank you for the PR, I'll check it early next week and will let you know.

@sergiud, that works for me on aarch64 Linux:

-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_gregs_REG_RIP
-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_gregs_REG_RIP - Failed
-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_sc_ip
-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_sc_ip - Failed
-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_pc
-- Performing Test HAVE_PC_FROM_UCONTEXT_uc_mcontext_pc - Success
$ cat config.h | grep PC
/* How to access the PC from a struct ucontext */
#define PC_FROM_UCONTEXT uc_mcontext.pc

Thank you!

CMakeLists.txt Outdated Show resolved Hide resolved
@sergiud
Copy link
Collaborator Author

sergiud commented Oct 9, 2023

@cieplik Thanks for validating the fix!

@sergiud sergiud merged commit b58718f into master Oct 9, 2023
268 of 269 checks passed
@sergiud sergiud deleted the cmake-ucontext branch October 9, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetPC() always returns nullptr
2 participants