Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging verbosity level flag to extract_ir.py #278

Merged

Commits on Jul 19, 2023

  1. Add logging verbosity level flag to extract_ir.py

    This commit adds a logging verbosity level flag to extract_ir.py and the
    appropriate plumbing/implementation in extract_ir_lib.py. This is
    primarily motivated by these errors coming up quite often in non-trivial
    builds (as it is fairly often there is some assembly or some flags don't
    get passed around somewhere) and not providing a very high signal to
    noise ratio, especially when used as a library against a bunch of
    projects at once.
    boomanaiden154 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c7e2903 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Address reviewer feedback

    - Don't change logging verbosity back to info to print the status
      message if the verbosity has been set lower.
    boomanaiden154 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d931d80 View commit details
    Browse the repository at this point in the history
  2. Address reviewer feedback

    - Log subprocess output directly rather than having subprocess write
      directly to STDOUT/STDERR.
    boomanaiden154 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    325158d View commit details
    Browse the repository at this point in the history
  3. Address reviewer feedback

    - Switch to using subprocess.check_output
    boomanaiden154 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    5bbf135 View commit details
    Browse the repository at this point in the history