cleanup editor export (#4086)

google · Feb 1, 2023 · f68fba9 · f68fba9
1 parent 8d63780
commit f68fba9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/space-opera/src/components/best_practices/constants.ts b/packages/space-opera/src/components/best_practices/constants.ts
@@ -44,11 +44,9 @@ const onProgress = (event) => {
   updatingBar.style.width = \`\${event.detail.totalProgress * 100}%\`;
   if (event.detail.totalProgress === 1) {
     progressBar.classList.add('hide');
+    event.target.removeEventListener('progress', onProgress);
   } else {
     progressBar.classList.remove('hide');
-    if (event.detail.totalProgress === 0) {
-      event.target.querySelector('.center-pre-prompt').classList.add('hide');
-    }
   }
 };
 document.querySelector('model-viewer').addEventListener('progress', onProgress);`;
diff --git a/packages/space-opera/src/components/best_practices/render_best_practices.ts b/packages/space-opera/src/components/best_practices/render_best_practices.ts
@@ -16,6 +16,7 @@
  */
 
 import {html} from 'lit';
+
 import {getMobileModelViewer} from '../mobile_view/reducer';
 import {getModelViewer} from '../model_viewer_preview/reducer';
 
@@ -42,9 +43,6 @@ export const onProgress = (event) => {
     event.target.removeEventListener('progress', onProgress);
   } else {
     progressBar.classList.remove('hide');
-    if (event.detail.totalProgress === 0) {
-      event.target.querySelector('.center-pre-prompt')?.classList.add('hide');
-    }
   }
 };
 

diff --git a/packages/space-opera/src/components/best_practices/styles.css.ts b/packages/space-opera/src/components/best_practices/styles.css.ts
@@ -21,11 +21,15 @@ export const modelViewerStyles: CSSResult = css`:not(:defined) > * {
   display: none;
 }
 
+html {
+  height: 100%;
+}
+
 body {
   margin: 0;
   padding: 0;
-  width: 100vw;
-  height: 100vh;
+  width: 100%;
+  height: 100%;
 }
 
 model-viewer {