Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DPR cap #4896

Merged
merged 1 commit into from
Sep 23, 2024
Merged

remove DPR cap #4896

merged 1 commit into from
Sep 23, 2024

Conversation

elalish
Copy link
Collaborator

@elalish elalish commented Sep 23, 2024

For the history of MV, we have only taken device pixel ratio (DPR) into account when a <meta viewport> tag was present on the page, since the default page scaling that happens on mobile browsers could cause us to render at far too high a pixel density and kill performance. However, we've now had dynamic render scaling built in for some time that dynamically reduces pixel density to maintain frame rate as necessary, and this is a much safer and more general approach to the problem.

We've occasionally run into pages that don't both to put a <meta viewport> tag in, even though they are modern pages, and high pixel-density screens are more and more common even on desktop, so I think at this point it's safer to remove our heuristic. This will ensure we are rendering at screen resolution across devices, and only downsampling under performance constraints.

@elalish elalish merged commit 5604ec8 into master Sep 23, 2024
5 checks passed
@elalish elalish deleted the alwaysUseDPR branch September 23, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant