Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(volume-rendering): picking, depth testing, and blending improvements #589

Merged
merged 44 commits into from
Jul 24, 2024

Conversation

seankmartin
Copy link
Contributor

@seankmartin seankmartin commented May 20, 2024

Allows picking via a second pass through max projection in volume rendering. The second pass only runs when the camera is still currently.

Also includes a fix for cases where a non-transparent object was in the middle of a volume rendering chunk. Sometimes the early depth testing would prevent some volume rendering which should have been performed. Now, the volume rendering always performs depth testing during the fragment shader, by computing the depth along rays, and comparing that to a depth value that is sampled from a texture buffer storing the Z value for non-transparent objects.

One other improvement is included, which is to blend together the volume rendering buffer and regular transparent buffer using OIT. Before, the VR buffer rendered to the main color buffer, and then the transparent buffer was rendered to the main color buffer. Now the VR buffer and transparent buffer are combined, then the combination rendered to the main color buffer.

image

@seankmartin seankmartin marked this pull request as ready for review May 23, 2024 12:32
@seankmartin seankmartin marked this pull request as draft June 12, 2024 12:37
@seankmartin seankmartin marked this pull request as ready for review June 21, 2024 14:57
@seankmartin seankmartin marked this pull request as draft July 4, 2024 09:33
@seankmartin seankmartin marked this pull request as ready for review July 8, 2024 09:40
@seankmartin seankmartin marked this pull request as draft July 8, 2024 13:20
@seankmartin seankmartin marked this pull request as ready for review July 8, 2024 16:21
@seankmartin seankmartin changed the title Feature - picking in non projection volume rendering feat(volume-rendering): picking in non projection volume rendering Jul 18, 2024
@seankmartin seankmartin changed the title feat(volume-rendering): picking in non projection volume rendering feat(volume-rendering): picking, depth testing, and blending improvements Jul 23, 2024
@jbms
Copy link
Collaborator

jbms commented Jul 24, 2024

This looks good, can you please rebase it so that it can be merged?

Thanks

This always had the same value as "hasVolumeRendering", so "hasVolumeRendering" is used instead
@jbms jbms merged commit 4e378b4 into google:master Jul 24, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants