-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(volume-rendering): picking, depth testing, and blending improvements #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to run second passes in different modes in the background, without affecting the UI value
…feature/picking-in-non-max-vr
Also only redraw if volume rendering is present after camera motion
…e/picking-in-non-max-vr
…s or histogram is used
seankmartin
changed the title
Feature - picking in non projection volume rendering
feat(volume-rendering): picking in non projection volume rendering
Jul 18, 2024
seankmartin
changed the title
feat(volume-rendering): picking in non projection volume rendering
feat(volume-rendering): picking, depth testing, and blending improvements
Jul 23, 2024
This looks good, can you please rebase it so that it can be merged? Thanks |
This always had the same value as "hasVolumeRendering", so "hasVolumeRendering" is used instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows picking via a second pass through max projection in volume rendering. The second pass only runs when the camera is still currently.
Also includes a fix for cases where a non-transparent object was in the middle of a volume rendering chunk. Sometimes the early depth testing would prevent some volume rendering which should have been performed. Now, the volume rendering always performs depth testing during the fragment shader, by computing the depth along rays, and comparing that to a depth value that is sampled from a texture buffer storing the Z value for non-transparent objects.
One other improvement is included, which is to blend together the volume rendering buffer and regular transparent buffer using OIT. Before, the VR buffer rendered to the main color buffer, and then the transparent buffer was rendered to the main color buffer. Now the VR buffer and transparent buffer are combined, then the combination rendered to the main color buffer.