feat: JPEG-XL Support (encoding: "jxl") #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you add support for an |
|
sure, will do. |
|
Ok! I think I set it up correctly. |
|
Can you fix the formatting (see updated CONTRIBUTING.md) and also fix the wasm reproducibility issue? |
|
Seems like even though generating on MacOS (on the same machine) is consistent, ubuntu is doing something different. I'll have to try again on an Ubuntu machine. |
|
@jbms I rebuilt the wasm on an Ubuntu machine. Please see if the reproducibility issue is fixed by running the check again. |
|
Hi just wanted to check in and see if this is good to merge. <3 Thanks for all your hard work Jeremy. Once this merges, we'll start using JXL (lossless at the very least) on an industrial scale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jeremy,
My lab has been exploring JPEG-XL for some time, and I finally got it working in my neuroglancer branch. I think it would be a good contribution to the ecosystem.
CloudVolume and Igneous both currently support JPEG-XL.
The implementation here uses the jxl-oxide implemention in Rust which I found easier to integrate than the C++ reference implementation.
Let me know what you think!
This was tested with both Grayscale and RGB color.