Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build in test subdirectories #3845

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

lnikkila
Copy link
Contributor

@lnikkila lnikkila commented Jul 4, 2023

Due to the regexes, ortools_pdlp fails to build if any of its parent directories starts with test or gtest:

CMake Error at test/ortools-src/ortools/pdlp/CMakeLists.txt:27 (add_library):
  No SOURCES given to target: ortools_pdlp

Due to the regexes, ortools_pdlp fails to build if any of its parent
directories starts with `test` or `gtest`:

    CMake Error at test/ortools-src/ortools/pdlp/CMakeLists.txt:27 (add_library):
      No SOURCES given to target: ortools_pdlp
@lnikkila lnikkila force-pushed the fix-test-subdirectory-builds branch from 730157f to 39edf98 Compare July 4, 2023 20:00
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thx for the fix !

@Mizux Mizux merged commit ab9b9a0 into google:main Jul 5, 2023
110 of 131 checks passed
@Mizux Mizux self-assigned this Jul 5, 2023
@Mizux Mizux added Bug Build: CMake CMake based build issue labels Jul 5, 2023
@Mizux Mizux added this to the v9.7 milestone Jul 5, 2023
@lnikkila lnikkila deleted the fix-test-subdirectory-builds branch July 5, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build: CMake CMake based build issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants