refactor: use .gohtml extension rather than suffixing templates with _template
#1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 68.75% 68.74% -0.02%
==========================================
Files 184 184
Lines 17714 17714
==========================================
- Hits 12180 12177 -3
- Misses 4875 4877 +2
- Partials 659 660 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks! I'll close this PR for now since the original files have been modified (lots of conflicts). I'll make the changes in a follow-up PR where I'll also refactor the code a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that IDEs like Goland automatically infer these files as Go templates, while still making it clear what files are templates vs "native" files