Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow configuration of java executable #742

Closed
wfhartford opened this issue Jan 3, 2024 · 2 comments
Closed

Feature Request: Allow configuration of java executable #742

wfhartford opened this issue Jan 3, 2024 · 2 comments
Milestone

Comments

@wfhartford
Copy link
Contributor

Currently the java executable used for protoc plugin JARs is inferred based on the JVM running gradle and it's java.home property. In most cases this means either the java executable on the system's PATH or the system's JAVA_HOME environment variable. While this is a great default, I have a protoc plugin JAR that is compiled for JDK 21 and some developers may not want to set their system wide JDK to 21.

It should be relatively straight forward to add a property to the GenerateProtoTask allowing a user to specify an arbitrary java executable in their build file.

Would a pull request adding this feature be accepted?

@ejona86
Copy link
Collaborator

ejona86 commented Mar 11, 2024

Without looking much at how that would be plumbed, that sounds fine. Feel free to send a PR.

@ejona86
Copy link
Collaborator

ejona86 commented Mar 14, 2024

Fixed by #750

@ejona86 ejona86 closed this as completed Mar 14, 2024
@ejona86 ejona86 added this to the 0.10.0 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants