Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for find_packge? #192

Open
HolyMiss opened this issue Jun 2, 2021 · 2 comments
Open

Add support for find_packge? #192

HolyMiss opened this issue Jun 2, 2021 · 2 comments

Comments

@HolyMiss
Copy link

HolyMiss commented Jun 2, 2021

S2_USE_GLOG is invalid after install

@jmr
Copy link
Member

jmr commented Sep 6, 2021

What do you mean by "invalid"? It looks like you just need to keep building with -DS2_USE_GLOG if you want to use glog.

How should we use find_package to make this better?

@HolyMiss HolyMiss closed this as completed Nov 3, 2021
@HolyMiss HolyMiss reopened this Nov 3, 2021
@HolyMiss
Copy link
Author

HolyMiss commented Nov 3, 2021

I add S2_USE_GLOG when compiling. After I make install, if I do not add S2_USE_GLOG in my code, it will report an error. If I add this macro, it will be injected into my code, so a better way is to provide find_package Mode, Add the S2_USE_GLOG macro in S2Config.cmake if it is used during compilation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants