Use shared ForkClientContext for generated sandboxees by default

PiperOrigin-RevId: 643247505 Change-Id: I079e43394bc7a9c86159f4512138440966a00b50
google · Jun 14, 2024 · 9d92acb · 9d92acb
1 parent bc350a9
commit 9d92acb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/sandboxed_api/tools/clang_generator/emitter.cc b/sandboxed_api/tools/clang_generator/emitter.cc
@@ -107,7 +107,12 @@ constexpr absl::string_view kEmbedClassTemplate = R"(
 // Sandbox with embedded sandboxee and default policy
 class %1$s : public ::sapi::Sandbox {
  public:
-  %1$s() : ::sapi::Sandbox(%2$s_embed_create()) {}
+  %1$s()
+      : ::sapi::Sandbox([]() {
+          static auto* fork_client_context =
+              new ::sapi::ForkClientContext(%2$s_embed_create());
+          return fork_client_context;
+        }()) {}
 };
 
 )";

diff --git a/sandboxed_api/tools/python_generator/code.py b/sandboxed_api/tools/python_generator/code.py
@@ -739,10 +739,16 @@ class Generator(object):
   GUARD_START = ('#ifndef {0}\n' '#define {0}')
   GUARD_END = '#endif  // {}'
   EMBED_INCLUDE = '#include "{}"'
-  EMBED_CLASS = ('class {0}Sandbox : public ::sapi::Sandbox {{\n'
-                 ' public:\n'
-                 '  {0}Sandbox() : ::sapi::Sandbox({1}_embed_create()) {{}}\n'
-                 '}};')
+  EMBED_CLASS = '''
+class {0}Sandbox : public ::sapi::Sandbox {{
+  public:
+    {0}Sandbox()
+      : ::sapi::Sandbox([]() {{
+          static auto* fork_client_context =
+              new ::sapi::ForkClientContext({1}_embed_create());
+          return fork_client_context;
+        }}()) {{}}
+}};'''
 
   def __init__(self, translation_units):
     # type: (List[cindex.TranslationUnit]) -> None