Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build flags for s390x, ppc64, and ppc64le #489

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

alexsaezm
Copy link
Contributor

According to the documentation, ppc64x is not a valid flag, making TestIntFallback fail. s390x is also missing and it works fine.

--- FAIL: TestIntFallback (0.01s)
    int_test.go:130: expected warning was not printed. Output=<<>>

Copy link
Collaborator

@adonovan adonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adonovan adonovan merged commit 08598ae into google:master Jul 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants