Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add showcase tests for mixins #2175

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 20, 2024

Towards #2156

Depends on #2186

@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 20, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Sep 20, 2024
@parthea parthea changed the base branch from main to pre-compute-wrappers-for-mixins September 23, 2024 23:20
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Sep 23, 2024
@parthea
Copy link
Contributor Author

parthea commented Sep 24, 2024

showcase (3.12, showcase_w_rest_async) is failing. This may need to be built on top of #2181

@ohmayr ohmayr force-pushed the pre-compute-wrappers-for-mixins branch from 99c7e17 to 0d32850 Compare September 24, 2024 03:50
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Sep 24, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Sep 24, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Sep 24, 2024
Base automatically changed from pre-compute-wrappers-for-mixins to async-rest-support-in-gapics September 24, 2024 16:19
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Sep 24, 2024
@ohmayr ohmayr changed the base branch from async-rest-support-in-gapics to implement-async-rest-mixins-call-method September 24, 2024 18:23
@ohmayr ohmayr force-pushed the implement-async-rest-mixins-call-method branch from 931feda to 4e52cd7 Compare September 24, 2024 18:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Sep 24, 2024
@ohmayr ohmayr marked this pull request as ready for review September 24, 2024 19:55
@ohmayr ohmayr requested a review from a team as a code owner September 24, 2024 19:55
Base automatically changed from implement-async-rest-mixins-call-method to async-rest-support-in-gapics September 25, 2024 15:01
tests/system/test_mixins.py Outdated Show resolved Hide resolved
tests/system/test_mixins.py Outdated Show resolved Hide resolved
@ohmayr ohmayr merged commit 2d9f2ef into async-rest-support-in-gapics Sep 25, 2024
72 checks passed
@ohmayr ohmayr deleted the add-mixin-tests branch September 25, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants