Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow google-cloud-kms 3.x #2226

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: allow google-cloud-kms 3.x #2226

merged 1 commit into from
Oct 16, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 16, 2024

google-cloud-kms 3.0.0 was released on September 23 2024. We need to bump the upper bound in _pypi_packages.j2

gapic-generator-python/gapic/templates/_pypi_packages.j2

Line 15 in 034191e

("google", "cloud", "kms", "v1"): {"package_name": "google-cloud-kms", "lower_bound": "2.3.0", "upper_bound": "3.0.0dev"},

https://pypi.org/project/google-cloud-kms/3.0.0/

Closes googleapis/google-cloud-python#13162

@parthea parthea requested a review from a team as a code owner October 16, 2024 17:17
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 16, 2024
@parthea parthea merged commit 5e07501 into main Oct 16, 2024
75 checks passed
@parthea parthea deleted the parthea-patch-4 branch October 16, 2024 17:40
@release-please release-please bot mentioned this pull request Oct 16, 2024
Merged
gkevinzheng pushed a commit that referenced this pull request Oct 22, 2024
@parthea @gkevinzheng
fix: allow google-cloud-kms 3.x (#2226)
ae9ea6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @ohmayr